From 73365e2a43027e1286874acf238ed89f88b6b333 Mon Sep 17 00:00:00 2001 From: Idan Kamara Date: Wed, 21 Dec 2011 15:06:18 +0200 Subject: [PATCH] Use subprocess.check_output so output will be logged Currently results in a traceback when the command fails. Ideally we should actually log stderr, since in most apps that's where the errors go when something goes wrong. --- hyde/plugin.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hyde/plugin.py b/hyde/plugin.py index c11e18f..a8e0fc9 100644 --- a/hyde/plugin.py +++ b/hyde/plugin.py @@ -389,7 +389,7 @@ class CLTransformer(Plugin): self.logger.debug( "Calling executable [%s] with arguments %s" % (args[0], unicode(args[1:]))) - subprocess.check_call(args) + subprocess.check_output(args) except subprocess.CalledProcessError, error: self.logger.error(traceback.format_exc()) self.logger.error(error.output)