From e74c636ca22130b18997017fddb116f9f7f9c905 Mon Sep 17 00:00:00 2001 From: German Larrain Date: Wed, 24 Jul 2013 20:17:44 -0400 Subject: [PATCH] Client.HTTPWithTimeout: fixed constructor's docstring and comments -named the diferences with respect to the overriden method -fixed wrong reference to class in module 'httplib' -added documentation of param 'timeout' -removed redundant comments --- src/SOAPpy/Client.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/SOAPpy/Client.py b/src/SOAPpy/Client.py index 52f8a29..c073c53 100644 --- a/src/SOAPpy/Client.py +++ b/src/SOAPpy/Client.py @@ -135,17 +135,19 @@ class HTTPWithTimeout(HTTP): _connection_class = HTTPConnectionWithTimeout - ## this __init__ copied from httplib.HTML class def __init__(self, host='', port=None, strict=None, timeout=None): - "Provide a default host, since the superclass requires one." + """Slight modification of superclass (httplib.HTTP) constructor. - # some joker passed 0 explicitly, meaning default port + The only change is that arg ``timeout`` is also passed in the + initialization of :attr:`_connection_class`. + + :param timeout: for the socket connection (seconds); None to disable + :type timeout: float or None + + """ if port == 0: port = None - # Note that we may pass an empty string as the host; this will throw - # an error when we attempt to connect. Presumably, the client code - # will call connect before then, with a proper host. self._setup(self._connection_class(host, port, strict, timeout)) class HTTPTransport: